wangsli和Claude Sonnet 5
cd01e4bf28
10-05 到期例外清单里已设计好的首批 4 个具体调用，现予落码（原方案见 implement.md §14「首批具体分支与验证要求」）： - ap_operations.feature_disabled（409）：AP 台账/明细查询功能关闭 - ap_operations.query_invalid（400）：AP 台账查询参数校验失败 - todo.feature_disabled（409）：待办功能关闭 - portal.feature_disabled（409）：工作台首页功能关闭 四处均改为调用 buildBusinessValidationError(reasonCode, details, statusCode)， 保留原 HTTP 状态码、featureFlag/reason 等既有 details 字段不变，仅新增精确 reasonCode；不改功能开关判断逻辑、不改权限校验顺序。 - server/src/constants/errorReasons.js + client/src/api/errorReasons.ts： 注册 4 条原因码及中文文案，服务端/客户端逐字一致。 - scripts/qa/error-reason-legacy-baseline.json：移除这 4 条已迁移的旧例外 记录（591 → 587），check-error-reason-contract.mjs 主检查与 self-test 均 PASS，无 new_legacy/stale_exception/unregistered_reason。 - apOperations.permissions.test.js：扩展"功能关闭"断言校验 reasonCode 与 原 details 字段共存；新增"查询参数非法（功能开启）"400 用例，断言零 台账业务查询；新增"合法查询仍 200"用例。 - portal.test.js：新增工作台关闭时 409+reasonCode+零业务查询断言（此前 完全没有覆盖这条路径）。 - todos.test.js：新建（此前 todos 路由零测试覆盖），聚焦 ensureFeatureEnabled 网关：关闭时 GET/POST 均 409+reasonCode+零 todoItem 查询；开启时正常放行。 验证：server 5 个相关测试文件 286/286 通过；client typecheck/build 通过； check-ui-design-rules.mjs --strict、check-trellis-governance.mjs、 git diff --check 通过。routes/ 全量回归 872/874（2 个失败为 paymentBatches BIFF8 导出的既有环境问题，已用 git stash 验证在改动前的 HEAD 上同样失败， 与本次改动无关，不在本次范围内处理）。 剩余 669 条例外记录不变，尚未处理；B/C 两档 57 文件仍需逐模块确认迁移或 提出延期理由，本次不扩大范围。 Co-Authored-By: Claude Sonnet 5 <[email protected]>
78 行
2.8 KiB
JavaScript
78 行
2.8 KiB
JavaScript
const Fastify = require("fastify");
|
|
const todosRoutes = require("../../../src/routes/todos");
|
|
const { AppError } = require("../../../src/utils/AppError");
|
|
|
|
async function buildApp({ featureEnabled = true } = {}) {
|
|
const app = Fastify();
|
|
const prisma = {
|
|
featureFlag: {
|
|
findUnique: vi.fn(async () => ({
|
|
flag_key: "todo_board_v1",
|
|
override_mode: featureEnabled ? "force_on" : "force_off",
|
|
rollout_type: "global",
|
|
department_ids: [],
|
|
})),
|
|
},
|
|
todoItem: {
|
|
findMany: vi.fn(async () => []),
|
|
create: vi.fn(),
|
|
findUnique: vi.fn(),
|
|
update: vi.fn(),
|
|
},
|
|
};
|
|
app.decorate("prisma", prisma);
|
|
app.decorate("config", { todoBoardEnabled: true });
|
|
app.decorate("authenticate", async (request) => {
|
|
request.employee = { id: "employee-1", department_id: "department-1", permissionCodes: [] };
|
|
});
|
|
app.decorate("hasPermission", () => false);
|
|
app.setErrorHandler((error, request, reply) => {
|
|
if (error instanceof AppError) {
|
|
return reply.code(error.statusCode).send({ error: { code: error.code, details: error.details ?? {} } });
|
|
}
|
|
return reply.code(500).send({ error: { code: "SYS_001" } });
|
|
});
|
|
await app.register(todosRoutes, { prefix: "/api" });
|
|
return { app, prisma };
|
|
}
|
|
|
|
describe("todos feature gate", () => {
|
|
it("returns a precise reasonCode and skips todo reads when the board is disabled", async () => {
|
|
const { app, prisma } = await buildApp({ featureEnabled: false });
|
|
try {
|
|
const getResponse = await app.inject({ method: "GET", url: "/api/todos" });
|
|
expect(getResponse.statusCode).toBe(409);
|
|
expect(getResponse.json()).toEqual({
|
|
error: {
|
|
code: "VALID_001",
|
|
details: { featureFlag: "todo_board_v1_disabled", reason: "flag_force_off", reasonCode: "todo.feature_disabled" },
|
|
},
|
|
});
|
|
expect(prisma.todoItem.findMany).not.toHaveBeenCalled();
|
|
|
|
const postResponse = await app.inject({
|
|
method: "POST",
|
|
url: "/api/todos",
|
|
payload: { title: "合成待办" },
|
|
});
|
|
expect(postResponse.statusCode).toBe(409);
|
|
expect(postResponse.json().error.details.reasonCode).toBe("todo.feature_disabled");
|
|
expect(prisma.todoItem.create).not.toHaveBeenCalled();
|
|
} finally {
|
|
await app.close();
|
|
}
|
|
});
|
|
|
|
it("lists todos normally without leaking a reasonCode when the board is enabled", async () => {
|
|
const { app, prisma } = await buildApp({ featureEnabled: true });
|
|
try {
|
|
const response = await app.inject({ method: "GET", url: "/api/todos" });
|
|
expect(response.statusCode).toBe(200);
|
|
expect(response.json().data).toEqual({ items: [] });
|
|
expect(prisma.todoItem.findMany).toHaveBeenCalledTimes(1);
|
|
} finally {
|
|
await app.close();
|
|
}
|
|
});
|
|
});
|